Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable smart transactions for new users #12148

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: Enable smart transactions for new users #12148

wants to merge 8 commits into from
+90 −1,131

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Nov 1, 2024 •
edited
Loading

Description

This PR:

Related issues

Fixes:

Manual testing steps

  1. After installing the app a user will not see the STX opt in modal
  2. In Advanced Settings Smart Transactions will be on. A user can turn them off if they want

Screenshots/Recordings

Smart Transactions enabled by default in Advanced settings for new users:
image

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dan437 dan437 added the team-transactions Transactions team label Nov 1, 2024
@dan437 dan437 requested review from a team as code owners November 1, 2024 13:23
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dan437 dan437 marked this pull request as draft November 1, 2024 13:24
@dan437 dan437 marked this pull request as ready for review November 11, 2024 14:19
@dan437 dan437 requested a review from a team as a code owner November 11, 2024 14:19
@socket-security Socket Security
Copy link

socket-security bot commented Nov 11, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask/[email protected] None 0 139 kB metamaskbot

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

@dan437 dan437 added the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 69121fd
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/db986bf7-b77b-4b88-90df-5e0e70d84b7e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@dan437 dan437 requested a review from a team as a code owner November 12, 2024 13:16
@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 13, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 03f6744
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ccb5571a-cada-4ed1-a448-e9e31b3bd3d1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@cryptodev-2s cryptodev-2s mentioned this pull request Nov 13, 2024
Closed
7 tasks
@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: e50fe6e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7e73ddac-29fa-40b3-a63b-4e4134bd14f0

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cryptodev-2s cryptodev-2s added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: db4f3ae
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/238ec7c9-4b34-4629-9403-33952855ebdc

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@cryptodev-2s cryptodev-2s removed the Run Smoke E2E Triggers smoke e2e on Bitrise label Nov 13, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.32%. Comparing base (940258e) to head (fe1f26f).
Report is 18 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #12148      +/-   ##
==========================================
- Coverage   56.38%   56.32%   -0.07%     
==========================================
  Files        1791     1793       +2     
  Lines       40494    40509      +15     
  Branches     5087     5094       +7     
==========================================
- Hits        22833    22817      -16     
- Misses      16109    16135      +26     
- Partials     1552     1557       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dan437 dan437 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: fe1f26f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bb1278ca-40b6-4304-8d3b-53b57c3d16ad

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@dan437 dan437 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: c2e82a4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/88594720-fca6-4920-adfc-897eab53f0b8

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

chrisleewilcox
chrisleewilcox approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dan437 dan437 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 19ef539
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d1f386c3-3aa5-40ff-b175-cf2811821fd9

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dan437 dan437 added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1e44728
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ea4599d0-b73a-4742-98b0-ed6244e73be2

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

boneskull
boneskull approved these changes Nov 15, 2024
View reviewed changes
Copy link

@boneskull boneskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything concerning here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infiniteflower infiniteflower infiniteflower approved these changes

@chrisleewilcox chrisleewilcox chrisleewilcox approved these changes

@boneskull boneskull boneskull approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-transactions Transactions team
Projects
PR review queue
Status: Needs dev review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dan437 @codecov-commenter @boneskull @chrisleewilcox @infiniteflower @cryptodev-2s